summaryrefslogtreecommitdiff
path: root/cleopatre/application/libspid
diff options
context:
space:
mode:
authorYacine Belkadi2011-06-22 09:45:43 +0200
committerYacine Belkadi2011-06-23 13:42:59 +0200
commit934dfa995be67d4d1637e5cef37f4f17103d8d4e (patch)
treec9a9d65da06bfa4437d3c156b17df52107776dd4 /cleopatre/application/libspid
parentb6e6869e0bb37771ea26db9c7ebefb640a1d02c5 (diff)
cleo/app/libspid: remove unnecessary close() calls in libspid_config_write_item()
The fclose(fp_in) do close the underlying file descriptor, so the close(fd_in) is not necessary, and actually returns an error.
Diffstat (limited to 'cleopatre/application/libspid')
-rw-r--r--cleopatre/application/libspid/src/config_item.c3
1 files changed, 0 insertions, 3 deletions
diff --git a/cleopatre/application/libspid/src/config_item.c b/cleopatre/application/libspid/src/config_item.c
index 98be689e1c..4172370312 100644
--- a/cleopatre/application/libspid/src/config_item.c
+++ b/cleopatre/application/libspid/src/config_item.c
@@ -149,7 +149,6 @@ libspid_error_t libspid_config_write_item(const char *filename, const char *labe
if ( (fp_out = fdopen(mkstemp(out_filename), "w")) == NULL )
{
fclose(fp_in);
- close(fd_in);
return LIBSPID_ERROR_SYSTEM;
}
/* find the label to modify */
@@ -174,7 +173,6 @@ libspid_error_t libspid_config_write_item(const char *filename, const char *labe
{
fclose(fp_out);
fclose(fp_in);
- close(fd_in);
return LIBSPID_ERROR_NO_SPACE;
}
/* write the new value */
@@ -189,7 +187,6 @@ libspid_error_t libspid_config_write_item(const char *filename, const char *labe
}
fclose(fp_out);
fclose(fp_in);
- close(fd_in);
if ( rename(out_filename, filename) < 0 )
{
//syslog(LOG_WARNING, "libspid_write_config_param : rename (errno=%d)\n", errno);