summaryrefslogtreecommitdiff
path: root/doc/todo/proposal:_env_vars_PROPELLOR__95__SPIN__95__BRANCH___38___PROPELLOR__95__DIRTY__95__NOSPIN/comment_1_432c6009fbe2309af81a47658173f753._comment
blob: 9b9ea8646f841df26305d07ce1acb30d19c3617e (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
[[!comment format=mdwn
 username="joey"
 subject="""comment 1"""
 date="2015-12-06T21:14:36Z"
 content="""
I'd use `PROPELLOR_SPIN_BRANCH`. No objections to `PROPELLOR_DIRTY_NOSPIN`
as long as it's not default.

Note that Cron.runPropellor does not use /usr/bin/propellor, and there are
other ways of running propellor that don't use that wrapper. So I don't
think the wrapper is the place to implement this kind of thing.

Why use environment variables for configuration? That makes it hard to make
sure propellor gets the same configuration every way it can be run. And,
propellor has a config file. :)

Implementation could be something like, add a `configuredMain` that takes a
monoidial configuration value for such global config settings. 
(so `defaultMain = configuredMain mempty`)

Hmm, I suppose the issue with `PROPELLOR_SPIN_BRANCH` is that when a
different branch is checked out, that branch's config.hs would not have that
configured, or would perhaps set it to use that branch. So, that's why
you were thinking environment variables?

Maybe use git-config?
"""]]