summaryrefslogtreecommitdiff
path: root/doc/todo/merge_request:_changes_to_Reboot.hs/comment_9_233140189ee7ffebad687db76dfe2258._comment
blob: 1afbef1150e9b81e9055ac5b53b4eb3f6d4b8af2 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
[[!comment format=mdwn
 username="joey"
 subject="""comment 9"""
 date="2016-06-20T17:56:25Z"
 content="""
Félix sent some patches today fixing compiling Propellor.Exception on old
ghc, which overlap with part of your patch. You addressed the same problem
in different ways. Since I already merged his (more extensive I think)
fixes for that, your branch will need to be updated.

The only thing I caught during review is that the documentation for
useOverlays says that the property has to be added before
Sbuild.builtFor, but actually info-setting properties
set info before any properties run, so can safely appear after properties
that use the info they set!

(I'm not sure if overlaysInTmpfs can safely come after 
Sbuild.builtFor, but if it cannot it's not due to setting useOverlays.)

Also, it would be good to have some lines to add to the changelog
about the sbuild changes.
"""]]