summaryrefslogtreecommitdiff
path: root/doc/todo/Fix_Borg.init_on_recent_borg_versions__44___fix_Borg.restored/comment_4_7685b1c27b0873b9149bc761f4e734af._comment
blob: 71ce0ac4660b7bc5c03052c67aee2040d6275d74 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
[[!comment format=mdwn
 username="joey"
 subject="""comment 4"""
 date="2020-08-14T16:44:43Z"
 content="""
I've merged your branch, thanks.

It does seem to me that Borg.init could do the privdata lookup itself, and
set `BORG_PASSPHRASE`. Otherwise the user is currently left with no
indication of how to do that, except for the commit message
[[!commit afab5b2f0b4e06a5c41f064d10f65ead063ab5af]].

And, for BorgEncRepokey and BorgEncKeyfile, wouldn't backup and restore
also need the passphrase to be provided?

(I don't think these questions need to delay releasing propellor with your
fixes, since AFAICS your changes won't impact anything that worked with
propellor before.)
"""]]