summaryrefslogtreecommitdiff
path: root/doc/forum/Git.cloned_deletes_harmless_empty_directory/comment_1_7cd0521c6d071b25852f8355f4f61f94._comment
blob: 91b403b08e75128997c0f75e0d520350d5712f7e (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
[[!comment format=mdwn
 username="joey"
 subject="""comment 1"""
 date="2017-04-05T02:22:54Z"
 content="""
I am not entirely happy with this patch, because it seems that if
Git.cloned took care to preserve permissions in this case, it could be
argued that it should also preserve permissions when the directory already
exists but has the wrong content. Or equally well argued that it should not
preserve permissions, which might be a leftover from some past unwanted
state.

Is that really the best way to do it? You could instead say:

	Git.cloned user repo dir Nothing
		`onChange` recursiveSetGID user dir

And then you just have to write a recursiveSetGID which would be a
generally useful property.
"""]]