From 35435e16b63771c65f8223ff3fd2580cc8bad856 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Mon, 8 Apr 2019 11:13:56 -0400 Subject: Fix bug in File.containsShellSetting It replaced whole shell conffile content with the setting if the file did not previously contain a line setting the key to some value. InsertSection is passed the whole content of the file, which does not contain the section yet (here the section is a single line). Probably this was not noticed because it's common for a shell config file to contain default values, so the buggy InsertSection rarely gets used. This commit was sponsored by Ethan Aubin. --- src/Propellor/Property/ConfFile.hs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src') diff --git a/src/Propellor/Property/ConfFile.hs b/src/Propellor/Property/ConfFile.hs index 0682e466..95e2c2d5 100644 --- a/src/Propellor/Property/ConfFile.hs +++ b/src/Propellor/Property/ConfFile.hs @@ -161,7 +161,7 @@ containsShellSetting f (k, v) = adjust `before` dedup isline (not . isline) (const [line]) - (const [line]) + (++ [line]) f dedup = fileProperty "" dedup' f dedup' ls = let (pre, wanted, post) = foldl' find ([], [], []) ls -- cgit v1.2.3