From df91695d31d5c4d527af0532bebf36e8580c89e9 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Wed, 25 Nov 2015 11:30:25 -0400 Subject: review --- .../comment_1_3c528827f40420e3f4001f69127a0c51._comment | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) create mode 100644 doc/todo/pull_request:_Locale.selectedFor_and_Locale.available_properties/comment_1_3c528827f40420e3f4001f69127a0c51._comment (limited to 'doc') diff --git a/doc/todo/pull_request:_Locale.selectedFor_and_Locale.available_properties/comment_1_3c528827f40420e3f4001f69127a0c51._comment b/doc/todo/pull_request:_Locale.selectedFor_and_Locale.available_properties/comment_1_3c528827f40420e3f4001f69127a0c51._comment new file mode 100644 index 00000000..4d413c84 --- /dev/null +++ b/doc/todo/pull_request:_Locale.selectedFor_and_Locale.available_properties/comment_1_3c528827f40420e3f4001f69127a0c51._comment @@ -0,0 +1,17 @@ +[[!comment format=mdwn + username="joey" + subject="""comment 1""" + date="2015-11-25T15:24:10Z" + content=""" +The types here don't tell me much about what values it expects. + +`selectedFor :: String -> [String] -> Property NoInfo` + +Function needs either some examples in its haddock, or better types. + +Also, the `available` property incorrectly succeeds if the locale passed to +it is not listed in locale.gen. + +(It would be nice for these properties to be revertable but that's just a +thought.) +"""]] -- cgit v1.2.3