From db0a38f02e1dda6ce35c782fa6132f344b0905d1 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Sat, 5 Dec 2015 18:57:56 -0400 Subject: followup --- ...tch_Apt.buildDep_to_only_proceed_if_installable.mdwn | 3 +++ ...comment_12_1e09f5a3f4565a9392d7b50b703a8a69._comment | 17 +++++++++++++++++ 2 files changed, 20 insertions(+) create mode 100644 doc/todo/pull_request:_patch_Apt.buildDep_to_only_proceed_if_installable/comment_12_1e09f5a3f4565a9392d7b50b703a8a69._comment (limited to 'doc') diff --git a/doc/todo/pull_request:_patch_Apt.buildDep_to_only_proceed_if_installable.mdwn b/doc/todo/pull_request:_patch_Apt.buildDep_to_only_proceed_if_installable.mdwn index a27dc2e1..275ea9f5 100644 --- a/doc/todo/pull_request:_patch_Apt.buildDep_to_only_proceed_if_installable.mdwn +++ b/doc/todo/pull_request:_patch_Apt.buildDep_to_only_proceed_if_installable.mdwn @@ -1,3 +1,6 @@ Please consider merging branch `builddepfix` of repo `https://git.spwhitton.name/propellor` Patches `Apt.buildDep` to check whether the build deps are installable, so that it no longer registers a change every spin. + +> Apt.buildDep now checks if the dpkg status file has changed, so [[done]] +> --[[Joey]] diff --git a/doc/todo/pull_request:_patch_Apt.buildDep_to_only_proceed_if_installable/comment_12_1e09f5a3f4565a9392d7b50b703a8a69._comment b/doc/todo/pull_request:_patch_Apt.buildDep_to_only_proceed_if_installable/comment_12_1e09f5a3f4565a9392d7b50b703a8a69._comment new file mode 100644 index 00000000..3db6fd1b --- /dev/null +++ b/doc/todo/pull_request:_patch_Apt.buildDep_to_only_proceed_if_installable/comment_12_1e09f5a3f4565a9392d7b50b703a8a69._comment @@ -0,0 +1,17 @@ +[[!comment format=mdwn + username="joey" + subject="""comment 12""" + date="2015-12-05T22:52:42Z" + content=""" +I had a thought about this; +[[trivial is a code smell|type-level_trivial_avoidance]] and adding +UncheckedProperty type avoids needing to use trivial. + +So, now cmdProperty, runApt, and other things that make a Property but +can't really detect when it MadeChange can instead make an +UncheckedProperty, and changesFile is one of the ways to convert that into +a Property. + +My implementation also allows applying changesFile multiple times, to +detect a change to multiple files. +"""]] -- cgit v1.2.3