From d738536788c916221e16470d6480db7414b91c13 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Fri, 20 Jul 2018 12:04:42 -0400 Subject: response --- ...ent_1_c73740e45387fe817280b55bb0e32c12._comment | 29 ++++++++++++++++++++++ 1 file changed, 29 insertions(+) create mode 100644 doc/todo/support_for_libvirt_KVM_VMs/comment_1_c73740e45387fe817280b55bb0e32c12._comment (limited to 'doc/todo/support_for_libvirt_KVM_VMs/comment_1_c73740e45387fe817280b55bb0e32c12._comment') diff --git a/doc/todo/support_for_libvirt_KVM_VMs/comment_1_c73740e45387fe817280b55bb0e32c12._comment b/doc/todo/support_for_libvirt_KVM_VMs/comment_1_c73740e45387fe817280b55bb0e32c12._comment new file mode 100644 index 00000000..24ad2c45 --- /dev/null +++ b/doc/todo/support_for_libvirt_KVM_VMs/comment_1_c73740e45387fe817280b55bb0e32c12._comment @@ -0,0 +1,29 @@ +[[!comment format=mdwn + username="joey" + subject="""comment 1""" + date="2018-07-20T15:54:17Z" + content=""" +That seems like a good plan to me, and nice use of the Conductor module. + +Of course, `conducts` is a Property, not an IO action and presumably +so is `debootstrapTheChrootAndPackIntoQcow2File`, +so to check if the disk image exists, you'll instead +want to use the `check` combinator. Something like: + + & check (doesFileExist "/path/to/image.qcow2") + debootstrapTheChrootAndPackIntoQcow2File theHost + & check (not <$> doesFileExist "/path/to/image.qcow2") + conducts [theHost] `requires` KVM.booted theHost + +Perhaps the redundancy in that can be reduced with a new combinator +that chooses which action to run. + +You may want to also delete the chroot once the disk image is built. + +There could also be a minor gotcha with the Conductor module trying to +conduct the VM before it's gotten set up yet, at worst this would make +propellor display a warning. + +Let me know if you need help with this, +although I will next be available on July 30th. +"""]] -- cgit v1.2.3