From 9d4655cf55ec0ab2d95b707e6b5ff009f0515bcd Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Wed, 20 Dec 2017 18:16:14 -0400 Subject: two diskimage edge case fixes * DiskImage: Fix rsync crash when a mount point does not exist in the chroot. * Fix bug in unmountBelow that caused unmounting of nested mounts to fail. This commit was sponsored by Jack Hill on Patreon. --- ...mment_2_f90109eb016065586225fc59674c431c._comment | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) create mode 100644 doc/forum/imageBuiltFor_mount_points_not_automatically_created/comment_2_f90109eb016065586225fc59674c431c._comment (limited to 'doc/forum/imageBuiltFor_mount_points_not_automatically_created') diff --git a/doc/forum/imageBuiltFor_mount_points_not_automatically_created/comment_2_f90109eb016065586225fc59674c431c._comment b/doc/forum/imageBuiltFor_mount_points_not_automatically_created/comment_2_f90109eb016065586225fc59674c431c._comment new file mode 100644 index 00000000..d8655a59 --- /dev/null +++ b/doc/forum/imageBuiltFor_mount_points_not_automatically_created/comment_2_f90109eb016065586225fc59674c431c._comment @@ -0,0 +1,20 @@ +[[!comment format=mdwn + username="joey" + subject="""comment 2""" + date="2017-12-20T21:36:36Z" + content=""" +AFAICS, DiskImage.imageFinalized creates any mount points that were not +rsynced over from the chroot. But, I guess that partitionsPopulated is +expecting the mount point to exist in order to rsync its content over, +and if nothing created /boot/efi that would explain the rsync error. +I've added a check to prevent that problem. + +As for the unmount problem, it's a problem with the order +it traverses the mount points for unmounting. That is using +"unmountBelow" with the directory where the disk image partitions +are loop mounted. If that unmounts `boot` first, it will implicitly +unmount `boot/efi` (due to --lazy) and then will fail when it +tries to explicitly unmount it. Added sorting that should fix that. + +Let me know how that goes, I've not tested it with your config. +"""]] -- cgit v1.2.3