From 7a2a88c12805f277e1e89e63b006a0783ea8cc0b Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Tue, 4 Apr 2017 22:31:00 -0400 Subject: comments --- ...mment_1_8ab6b313c80486f8f87a5e13e830bfa9._comment | 20 ++++++++++++++++++++ ...mment_1_7cd0521c6d071b25852f8355f4f61f94._comment | 20 ++++++++++++++++++++ 2 files changed, 40 insertions(+) create mode 100644 doc/forum/Fstab.mounted_could_call_swapon_when_activating_swap/comment_1_8ab6b313c80486f8f87a5e13e830bfa9._comment create mode 100644 doc/forum/Git.cloned_deletes_harmless_empty_directory/comment_1_7cd0521c6d071b25852f8355f4f61f94._comment diff --git a/doc/forum/Fstab.mounted_could_call_swapon_when_activating_swap/comment_1_8ab6b313c80486f8f87a5e13e830bfa9._comment b/doc/forum/Fstab.mounted_could_call_swapon_when_activating_swap/comment_1_8ab6b313c80486f8f87a5e13e830bfa9._comment new file mode 100644 index 00000000..4a144df5 --- /dev/null +++ b/doc/forum/Fstab.mounted_could_call_swapon_when_activating_swap/comment_1_8ab6b313c80486f8f87a5e13e830bfa9._comment @@ -0,0 +1,20 @@ +[[!comment format=mdwn + username="joey" + subject="""comment 1""" + date="2017-04-05T02:17:00Z" + content=""" +This idea kind of makes sense, because swap partitions in /etc/fstab +get swaponed at boot. + +But, the implementation doesn't take the types into account. The `mounted` +property takes a FilePath for the mountpoint, but for swap that +needs to be "none", which is not really a file-path. Also, the `fstabbed` +property has a separate `SwapPartition` type, so making `mount` support +swap partitions without using that type feels wrong. + +It might be simpler all round to treat swap partitions being able to +be specified in /etc/fstab as a historical accident, which it kind of +is (increasingly so, since eg systemd has other ways to accomplish +that), and instead of shoehorning this into the `mounted` property, +add a new `swaponed` property. +"""]] diff --git a/doc/forum/Git.cloned_deletes_harmless_empty_directory/comment_1_7cd0521c6d071b25852f8355f4f61f94._comment b/doc/forum/Git.cloned_deletes_harmless_empty_directory/comment_1_7cd0521c6d071b25852f8355f4f61f94._comment new file mode 100644 index 00000000..91b403b0 --- /dev/null +++ b/doc/forum/Git.cloned_deletes_harmless_empty_directory/comment_1_7cd0521c6d071b25852f8355f4f61f94._comment @@ -0,0 +1,20 @@ +[[!comment format=mdwn + username="joey" + subject="""comment 1""" + date="2017-04-05T02:22:54Z" + content=""" +I am not entirely happy with this patch, because it seems that if +Git.cloned took care to preserve permissions in this case, it could be +argued that it should also preserve permissions when the directory already +exists but has the wrong content. Or equally well argued that it should not +preserve permissions, which might be a leftover from some past unwanted +state. + +Is that really the best way to do it? You could instead say: + + Git.cloned user repo dir Nothing + `onChange` recursiveSetGID user dir + +And then you just have to write a recursiveSetGID which would be a +generally useful property. +"""]] -- cgit v1.2.3