From 4df36434f50be58f413550dd36206f0c15a3e6f2 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Fri, 25 Aug 2017 19:05:25 -0400 Subject: Attic: Fix broken shell escaping in attic cron job. Didn't see this one fail, or test this, but it had exactly the same code as borg. --- debian/changelog | 1 + src/Propellor/Property/Attic.hs | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/debian/changelog b/debian/changelog index 4e8c66b8..c7cfb81a 100644 --- a/debian/changelog +++ b/debian/changelog @@ -9,6 +9,7 @@ propellor (4.8.0) UNRELEASED; urgency=medium Instead, use VirtualBoxPointer in the property that creates the disk image. * Borg: Fix broken shell escaping in borg cron job. + * Attic: Fix broken shell escaping in attic cron job. -- Joey Hess Thu, 24 Aug 2017 11:00:19 -0400 diff --git a/src/Propellor/Property/Attic.hs b/src/Propellor/Property/Attic.hs index 9e024356..8ab5546b 100644 --- a/src/Propellor/Property/Attic.hs +++ b/src/Propellor/Property/Attic.hs @@ -108,7 +108,7 @@ backup' dir backupdir crontimes extraargs kp = cronjob where desc = backupdir ++ " attic backup" cronjob = Cron.niceJob ("attic_backup" ++ dir) crontimes (User "root") "/" $ - "flock " ++ shellEscape lockfile ++ " sh -c " ++ backupcmd + "flock " ++ shellEscape lockfile ++ " sh -c " ++ shellEscape backupcmd lockfile = "/var/lock/propellor-attic.lock" backupcmd = intercalate ";" $ createCommand -- cgit v1.2.3