From 4a7448e9f22586419e3b9aefd8baa35fffa880b0 Mon Sep 17 00:00:00 2001 From: Sean Whitton Date: Sun, 12 Jun 2016 11:00:10 +0900 Subject: attempt to actually extract kernel version --- src/Propellor/Property/Reboot.hs | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/Propellor/Property/Reboot.hs b/src/Propellor/Property/Reboot.hs index 41234489..d3b2d372 100644 --- a/src/Propellor/Property/Reboot.hs +++ b/src/Propellor/Property/Reboot.hs @@ -8,6 +8,7 @@ module Propellor.Property.Reboot ( import Propellor.Base import Data.List +import Data.String.Utils (split) import Data.Version type KernelVersion = String @@ -69,7 +70,8 @@ newerKernelAvailable wantV = do kernelImages <- installedKernelImages when (null kernelImages) $ error "failed to find any installed kernel images" - let installedV = maximum $ Prelude.read <$> kernelImages + let installedV = maximum $ + Prelude.read . extractKernelVersion <$> kernelImages return $ installedV >= wantV && runningV < wantV runningInstalledKernel :: IO Bool @@ -97,3 +99,9 @@ findVersion ver s = (" version " ++ ver ++ " ") `isInfixOf` s kernelsIn :: FilePath -> IO [FilePath] kernelsIn d = filter ("vmlinu" `isInfixOf`) <$> dirContents d + +-- TODO this is way too crude +extractKernelVersion :: String -> KernelVersion +extractKernelVersion s = + concat . reverse . drop 1 . reverse . drop 1 $ + split "-" s -- cgit v1.2.3