summaryrefslogtreecommitdiff
path: root/doc/todo/bytes_in_privData__63__
diff options
context:
space:
mode:
Diffstat (limited to 'doc/todo/bytes_in_privData__63__')
-rw-r--r--doc/todo/bytes_in_privData__63__/comment_10_7812a96a98405d924a69e998dd42f275._comment9
-rw-r--r--doc/todo/bytes_in_privData__63__/comment_11_3839f018cbbd1043e645bf728162dea1._comment14
-rw-r--r--doc/todo/bytes_in_privData__63__/comment_8_07f4a5604e51ee3114853e5017ef2a5f._comment9
-rw-r--r--doc/todo/bytes_in_privData__63__/comment_9_7c87ab0fba0aa90e2b24b457851b63c4._comment17
4 files changed, 49 insertions, 0 deletions
diff --git a/doc/todo/bytes_in_privData__63__/comment_10_7812a96a98405d924a69e998dd42f275._comment b/doc/todo/bytes_in_privData__63__/comment_10_7812a96a98405d924a69e998dd42f275._comment
new file mode 100644
index 00000000..602f91f0
--- /dev/null
+++ b/doc/todo/bytes_in_privData__63__/comment_10_7812a96a98405d924a69e998dd42f275._comment
@@ -0,0 +1,9 @@
+[[!comment format=mdwn
+ username="andrew"
+ subject="comment 10"
+ date="2016-06-17T05:25:08Z"
+ content="""
+I've recreated my propellor repository a few times and have had to write out .pfx files. Essentially a binary format of .pem and .key. I had no problem getting the pfx file into privData, but propellor bails when writing the binary data on the host. This patch tackles the writing on host bit (not the writing to privData). You've used `hPutStr` to write out data which errors on certain bytes (because `hPutStr` assumes a character encoding?). 0x00 is a likely candidate. I don't recall the exact error, but at least Haskell noticed this and gave an error rather than writing out a partial file.
+
+I'll see if I can get a deduping patch to tidy up fileProperty and byteProperty.
+"""]]
diff --git a/doc/todo/bytes_in_privData__63__/comment_11_3839f018cbbd1043e645bf728162dea1._comment b/doc/todo/bytes_in_privData__63__/comment_11_3839f018cbbd1043e645bf728162dea1._comment
new file mode 100644
index 00000000..93094e84
--- /dev/null
+++ b/doc/todo/bytes_in_privData__63__/comment_11_3839f018cbbd1043e645bf728162dea1._comment
@@ -0,0 +1,14 @@
+[[!comment format=mdwn
+ username="joey"
+ subject="""comment 11"""
+ date="2016-06-17T13:16:17Z"
+ content="""
+Hmm, the way Strings are used for PrivData takes advantage of ghc's
+"filename encoding", which is supposed to allow arbitrary bytes to be
+included in filenames; unicode surrogate characters are used to map
+them to unicode.
+
+But, Property.File is using readFile, witeFile, and writeFileProtected,
+which will bail on invalid unicode as the filename encoding is not used.
+Your patch avoids that problem I see.
+"""]]
diff --git a/doc/todo/bytes_in_privData__63__/comment_8_07f4a5604e51ee3114853e5017ef2a5f._comment b/doc/todo/bytes_in_privData__63__/comment_8_07f4a5604e51ee3114853e5017ef2a5f._comment
new file mode 100644
index 00000000..11010dd2
--- /dev/null
+++ b/doc/todo/bytes_in_privData__63__/comment_8_07f4a5604e51ee3114853e5017ef2a5f._comment
@@ -0,0 +1,9 @@
+[[!comment format=mdwn
+ username="andrew"
+ subject="comment 8"
+ date="2016-06-15T06:44:55Z"
+ content="""
+This has bit me one too many times, so here is a full implementation. There could be some dedup work to merge fileProperty and byteProperty, but I'd rather not break API with a trivial bug fix.
+
+<https://github.com/arcticwaters/propellor/commit/f5a921760ccabf0a3ebdda626c19ee6ecbe89629>
+"""]]
diff --git a/doc/todo/bytes_in_privData__63__/comment_9_7c87ab0fba0aa90e2b24b457851b63c4._comment b/doc/todo/bytes_in_privData__63__/comment_9_7c87ab0fba0aa90e2b24b457851b63c4._comment
new file mode 100644
index 00000000..b904351a
--- /dev/null
+++ b/doc/todo/bytes_in_privData__63__/comment_9_7c87ab0fba0aa90e2b24b457851b63c4._comment
@@ -0,0 +1,17 @@
+[[!comment format=mdwn
+ username="joey"
+ subject="""comment 9"""
+ date="2016-06-17T01:33:05Z"
+ content="""
+Thank you, Andrew!
+
+Before I merge this, I want to clear up something that confuses me;
+you characterized this as a bug that has bit you. How did the
+pre-bytestring File.hasContentProtected exhibit buggy behavior?
+
+AFAICS, it already supported binary privdata, just in a suboptimal
+way.
+
+(Also fileProperty and bytesProperty should indeed be deduped;
+a second patch that merges them, even with an API change, would be ok.)
+"""]]