path: root/src/Propellor/Property/Group.hs
diff options
authorJoey Hess2015-12-05 17:52:43 -0400
committerJoey Hess2015-12-05 17:53:16 -0400
commit12548bae3d8feecce6a322162d91b827289ae824 (patch)
tree45f5ec5131817aab5133c9c1e4dbcf3364953e76 /src/Propellor/Property/Group.hs
parentb816e40e2618a8932144bceb7c7039adc5c44c11 (diff)
UncheckedProperty for cmdProperty et al
* Properties that run an arbitrary command, such as cmdProperty and scriptProperty are converted to use UncheckedProperty, since they cannot tell on their own if the command truely made a change or not. (API Change) Transition guide: - When GHC complains about an UncheckedProperty, add: `assume` MadeChange - Since these properties used to always return MadeChange, that change is always safe to make. - Or, if you know that the command should modifiy a file, use: `changesFile` filename * A few properties have had their Result improved, for example Apt.buldDep and Apt.autoRemove now check if a change was made or not.
Diffstat (limited to 'src/Propellor/Property/Group.hs')
1 files changed, 4 insertions, 2 deletions
diff --git a/src/Propellor/Property/Group.hs b/src/Propellor/Property/Group.hs
index ce8a8398..8499d636 100644
--- a/src/Propellor/Property/Group.hs
+++ b/src/Propellor/Property/Group.hs
@@ -5,8 +5,10 @@ import Propellor.Base
type GID = Int
exists :: Group -> Maybe GID -> Property NoInfo
-exists (Group group') mgid = check test (cmdProperty "addgroup" $ args mgid)
- `describe` unwords ["group", group']
+exists (Group group') mgid = check test $
+ cmdProperty "addgroup" (args mgid)
+ `assume` MadeChange
+ `describe` unwords ["group", group']
groupFile = "/etc/group"
test = not . elem group' . words <$> readProcess "cut" ["-d:", "-f1", groupFile]