path: root/doc/todo/LVM_logical_volume_creation__44___resize__44___format___38___removal
diff options
authorJoey Hess2017-08-31 19:03:12 -0400
committerJoey Hess2017-08-31 19:03:12 -0400
commit2218c28618fc918998fdb5aeb7f89f3105e918bb (patch)
treed89cdedf2a30a76584c7101aad3a9c34a6c974e7 /doc/todo/LVM_logical_volume_creation__44___resize__44___format___38___removal
parent7a2c0f6e3f27620c2dcf6a95e7a0f1c1f4f23f3e (diff)
Diffstat (limited to 'doc/todo/LVM_logical_volume_creation__44___resize__44___format___38___removal')
1 files changed, 26 insertions, 0 deletions
diff --git a/doc/todo/LVM_logical_volume_creation__44___resize__44___format___38___removal/comment_1_74c6576b25f74c6e620eb015af8b0f6a._comment b/doc/todo/LVM_logical_volume_creation__44___resize__44___format___38___removal/comment_1_74c6576b25f74c6e620eb015af8b0f6a._comment
new file mode 100644
index 00000000..5982361f
--- /dev/null
+++ b/doc/todo/LVM_logical_volume_creation__44___resize__44___format___38___removal/comment_1_74c6576b25f74c6e620eb015af8b0f6a._comment
@@ -0,0 +1,26 @@
+[[!comment format=mdwn
+ username="joey"
+ subject="""comment 1"""
+ date="2017-08-31T22:40:34Z"
+ content="""
+That's a pretty nice job for your first haskell code! And an impressive
+Most of my review comments have to do with improving types.. Which is
+always a nice way to improve already good code. :)
+* VolumeGroup and LogicalVolume seem like easy things to mix up.
+ Also, there's never a LogicalVolume without an associated VolumeGroup.
+ So, suggest `newtype VolumeGroup = VolumeGroup String` and
+ `data LogicalVolume = LogicalVolume String VolumeGroup` -- then
+ the user would write something like
+ `LogicalVolume "test" (VolumeGroup "vg0")`
+* Why not make `LvState` contain a `Maybe Partition.Fs` rather than
+ the string value. (This also would move the parsing of filesystem names
+ from `fsMatch` to `lvState` or perhaps to another function it uses.)
+* It seems a bit wrong for `parseSize` to include the rounding
+ to the next extent, which is not really related to parsing.
+ Would be better to split those two things into separate functions.
+I feel that this module is fairly close to mergeable.