|author||Joey Hess||2017-10-25 12:58:50 -0400|
|committer||Joey Hess||2017-10-25 13:00:23 -0400|
Make addInfo accumulate Info in order properties appear, not reverse order
This fixes a bug involving reverting Systemd.resolvConfed or Systemd.linkJournal. addInfo was prepending to the list for efficiency. But, that was in conflict with mappend of two Info, which appended the second to the first. In the case where Systemd.resolvConfed was added reverted, to override the one added by default, that led to a list of info that had first the reversion and then the default, so the default won. Which was wrong. So, make addInfo accumulate in the same order mappend combines things, even though it's a little less efficient. The efficiency probably does not matter; there is not typically a whole lot of info. There's some risk this change has unexpected consequences, if something relied on the old addInfo order without using fromInfo to access to info. But if so, that something would have been broken before when two Info properties were combined. With this change, it would just be broken the other way around. This commit was sponsored by Jochen Bartl on Patreon.
Diffstat (limited to 'doc/forum/Using_ip_address_in_a_container')
1 files changed, 13 insertions, 0 deletions
diff --git a/doc/forum/Using_ip_address_in_a_container/comment_5_338fa2c7d0fb389c0888ba8a9095719c._comment b/doc/forum/Using_ip_address_in_a_container/comment_5_338fa2c7d0fb389c0888ba8a9095719c._comment
new file mode 100644
@@ -0,0 +1,13 @@
+ subject="""comment 5"""
+@Nicolas, the reason it appears twice is that resolveConfed is added by
+default, and then you added it again reverted. That display could certianly
+be improved, perhaps by having it look to see if there's a resolveConfed
+setting before adding in the default one.
+As to why reverting it didn't work, that was a Info ordering bug, which
+I've now fixed.