summaryrefslogtreecommitdiff
path: root/doc/forum/Git.cloned_deletes_harmless_empty_directory/comment_1_7cd0521c6d071b25852f8355f4f61f94._comment
diff options
context:
space:
mode:
authorJoey Hess2017-04-09 17:52:04 -0400
committerJoey Hess2017-04-09 17:52:04 -0400
commitb0cb72410d59a5a111d4235dec05fda666ee6ff8 (patch)
treeede43750e4e95d9090ccb19beff067a2facb5035 /doc/forum/Git.cloned_deletes_harmless_empty_directory/comment_1_7cd0521c6d071b25852f8355f4f61f94._comment
parent6a632221a2d2d1e31859c8deb79543056224a76f (diff)
parent57525e0d0d1d300aa807f1c876945ee5e38a29df (diff)
Merge remote-tracking branch 'origin' into joeyconfig
Diffstat (limited to 'doc/forum/Git.cloned_deletes_harmless_empty_directory/comment_1_7cd0521c6d071b25852f8355f4f61f94._comment')
-rw-r--r--doc/forum/Git.cloned_deletes_harmless_empty_directory/comment_1_7cd0521c6d071b25852f8355f4f61f94._comment20
1 files changed, 20 insertions, 0 deletions
diff --git a/doc/forum/Git.cloned_deletes_harmless_empty_directory/comment_1_7cd0521c6d071b25852f8355f4f61f94._comment b/doc/forum/Git.cloned_deletes_harmless_empty_directory/comment_1_7cd0521c6d071b25852f8355f4f61f94._comment
new file mode 100644
index 00000000..91b403b0
--- /dev/null
+++ b/doc/forum/Git.cloned_deletes_harmless_empty_directory/comment_1_7cd0521c6d071b25852f8355f4f61f94._comment
@@ -0,0 +1,20 @@
+[[!comment format=mdwn
+ username="joey"
+ subject="""comment 1"""
+ date="2017-04-05T02:22:54Z"
+ content="""
+I am not entirely happy with this patch, because it seems that if
+Git.cloned took care to preserve permissions in this case, it could be
+argued that it should also preserve permissions when the directory already
+exists but has the wrong content. Or equally well argued that it should not
+preserve permissions, which might be a leftover from some past unwanted
+state.
+
+Is that really the best way to do it? You could instead say:
+
+ Git.cloned user repo dir Nothing
+ `onChange` recursiveSetGID user dir
+
+And then you just have to write a recursiveSetGID which would be a
+generally useful property.
+"""]]