path: root/doc/forum/Fstab.mounted_could_call_swapon_when_activating_swap
diff options
authorJoey Hess2017-04-06 20:08:14 -0400
committerJoey Hess2017-04-06 20:16:08 -0400
commit57525e0d0d1d300aa807f1c876945ee5e38a29df (patch)
treed5bd3df239cc9247980d45f9fafb550bd4679643 /doc/forum/Fstab.mounted_could_call_swapon_when_activating_swap
parent544ad71f3fce7d394945b447fcaf938d8067c5b3 (diff)
tweaks to db45x's patch
Removed mountNow as a top-level property, as I don't think it makes sense for anything except for mounted to use it. db45x's patch turns out to have introduced a bug in mounted's use of "mountNow src". That made mountNow check if the device was a mount point, which it isn't. The fix would have been to use "mountNow mnt", but my inlining of mountnow just basically reverted the part of the patch that introduced the bug. swapOn does not involve the fstab so moved to the Mount module. (Also noticed that Mount.mounted is a kind of weird property, given that it fails the next time ran. It's only used internally by some chroot properties, so I left it as-is, but added a comment. It might make sense to make Mount.mounted check like mountNow does if the thing is already mounted.)
Diffstat (limited to 'doc/forum/Fstab.mounted_could_call_swapon_when_activating_swap')
1 files changed, 14 insertions, 0 deletions
diff --git a/doc/forum/Fstab.mounted_could_call_swapon_when_activating_swap/comment_5_6dc24952c8efa31a401191a8cf2d0b39._comment b/doc/forum/Fstab.mounted_could_call_swapon_when_activating_swap/comment_5_6dc24952c8efa31a401191a8cf2d0b39._comment
new file mode 100644
index 00000000..f87500b2
--- /dev/null
+++ b/doc/forum/Fstab.mounted_could_call_swapon_when_activating_swap/comment_5_6dc24952c8efa31a401191a8cf2d0b39._comment
@@ -0,0 +1,14 @@
+[[!comment format=mdwn
+ username="joey"
+ subject="""comment 5"""
+ date="2017-04-06T23:51:08Z"
+ content="""
+Merged. Have not tested it either.
+On my Debian system, the swapon command does not support the
+`--no-headings` that you used. It's `--noheadings` here. Is that a typo in
+your patch?
+I've simply removed that option for now, since it probably won't
+hurt if it treats the heading like another device that's swapped on.