diff options
authorspwhitton2018-04-29 16:27:55 +0000
committeradmin2018-04-29 16:27:55 +0000
commit828e7d1ebefeeaf152910ad61f928a2f65607509 (patch)
parent5ab5f69e2729cceb85840305a46e7f296a04c4f9 (diff)
we should factor out code in Grub.configured
1 files changed, 15 insertions, 0 deletions
diff --git a/doc/todo/factor_out_Grub.configured_for_any___47__etc__47__default_config.mdwn b/doc/todo/factor_out_Grub.configured_for_any___47__etc__47__default_config.mdwn
new file mode 100644
index 00000000..6a97f8fb
--- /dev/null
+++ b/doc/todo/factor_out_Grub.configured_for_any___47__etc__47__default_config.mdwn
@@ -0,0 +1,15 @@
+It would be useful to have a property to set key value pairs in /etc/default configs. The code is in Grub.configured. I have not written a patch yet because I am not sure what the module should be called. Possibilities are:
+ & EtcDefault.set "anacron" "ANACRON_RUN_ON_BATTERY_POWER" "no"
+or maybe
+ & ConfFile.hasShellSetting "/etc/default/anacron" ("ANACRON_RUN_ON_BATTERY_POWER", "no")
+Or possibly both of these, with the former implemented in terms of the latter.
+* The use of a tuple for the last two parameters ensures that the property can be used infix.
+* I think this property should deduplicate the config key after setting it. I.e. after uncommenting and modifying ANACRON_RUN_ON_BATTERY_POWER it should remove any further ANACRON_RUN_ON_BATTERY_POWER settings further down the config. This allows a seamless transition from just using File.containsLine to add to the end of the file.