summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJoey Hess2015-10-21 17:22:04 -0400
committerJoey Hess2015-10-21 17:22:04 -0400
commit2d1671d5ebdd3c7f99d4023ac621137938505962 (patch)
treecbc536e66941a5438e95d58932055160a6555ae7
parentdd7812b3d814ecea6124d3cbedc329f6c6851bef (diff)
comment
-rw-r--r--doc/todo/support_tarball_source_images/comment_4_df41bdafff9277fb105ea2da0b0af5d9._comment37
1 files changed, 37 insertions, 0 deletions
diff --git a/doc/todo/support_tarball_source_images/comment_4_df41bdafff9277fb105ea2da0b0af5d9._comment b/doc/todo/support_tarball_source_images/comment_4_df41bdafff9277fb105ea2da0b0af5d9._comment
new file mode 100644
index 00000000..21c39d32
--- /dev/null
+++ b/doc/todo/support_tarball_source_images/comment_4_df41bdafff9277fb105ea2da0b0af5d9._comment
@@ -0,0 +1,37 @@
+[[!comment format=mdwn
+ username="joey"
+ subject="""comment 4"""
+ date="2015-10-21T21:07:53Z"
+ content="""
+I don't think it makes sense to add MinimalTarball as an operating System.
+
+If you make ChrootTarball contain the FilePath to the tarball,
+then ChrootBootstrapper ChrootTarball instance doesn't need to look
+at the system parameter at all; instead it can just look inside the
+ChrootTarball to get the path to it, and extract that.
+
+So, the user would write, say:
+
+ bootstrapped (System (Debian Unstable) "amd64") (ChrootTarball "/tmp/debian.tar.gz") "/chroot"
+
+What might make sense it to change the first parameter of boostrapped
+to Maybe System, for cases where you don't want to specify it.
+
+----
+
+It would probably also be good to document what kind of tarball is
+expected. Ie, that it can be compressed, and should not consist
+of a single subdirectory, but one subdirectory for each top-level
+root directory.
+
+----
+
+Also, as a minor point, I don't think you need to pass standardPathEnv;
+it should be fine to use boolSystem with the regular enviroment as
+far as I can see. In fact, you could probably simplify extractTarball
+by implementing it like this:
+
+ check (unpopulated target) $
+ cmdProperty "tar" params
+ `requires` File.dirExists target
+"""]]